Skip to content

CI: Default DEPLOY_SMOKE_003_EXECUTE=1 — deploy-smoke 003 execute in ci-local #1530

@PurHur

Description

@PurHur

Problem

#745 / #804 landed script/deploy-smoke.sh --example 003 (layout + opt-in execute). MiniWebAppAotExecuteTest is default-on (#747), but deploy path smoke for 003 remains opt-in:

  • script/ci-defaults.env: DEPLOY_SMOKE_003_EXECUTE="${DEPLOY_SMOKE_003_EXECUTE:-0}"
  • script/ci-common.sh only runs 003 execute when DEPLOY_SMOKE_003_EXECUTE=1 or MINIWEBAPP_AOT_EXECUTE_GATE=1 — the latter runs PHPUnit, not phpc deploy + PHPC_DEPLOY_ROOT

Regressions in phpc deploy packaging or deploy-tree CGI env for 003 would not fail full CI by default.

Goal

Flip default so ./script/ci-local.sh runs 003 deploy execute the same way 001/002 deploy smoke is default-on via DEPLOY_SMOKE_GATE=1.

Implementation hints

File Change
script/ci-defaults.env DEPLOY_SMOKE_003_EXECUTE="${DEPLOY_SMOKE_003_EXECUTE:-1}"
script/deploy-smoke.sh Update header comment + --help text
script/ci-common.sh Document new default in echo line
test/unit/MiniWebAppUnskipMatrixTest.php Assert default 1 in ci-defaults (mirror #1523 pattern)
phpc doctor --gates Optional row for deploy 003 execute (#657)

Acceptance criteria

grep 'DEPLOY_SMOKE_003_EXECUTE:-1' script/ci-defaults.env
./script/ci-local.sh   # deploy-smoke 003 execute runs without extra env
DEPLOY_SMOKE_003_EXECUTE=0 ./script/ci-local.sh   # skip path still works

Docker:

docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev ./script/ci-local.sh

No GitHub Actions required.

Dependencies

Links

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions