Skip to content

DevEx: phpc doctor --gates lists north-star1-verify presenter steps (#1845 phase 2) #1857

@PurHur

Description

@PurHur

Problem

#1845 ✅ added make north-star1-verify / script/north-star1-verify.sh as the presenter bundle before #1044 close. Contributors still discover it only via README or docs/miniwebapp-gates.mdphpc doctor --gates does not surface the script or its LLVM/serve skip flags.

Goal

Extend lib/Doctor.php (or Doctor::runGates) to print a North Star 1 presenter section:

Step Command Notes
Gates ladder make miniwebapp-gates stages 0–4d
Fast CI ./script/ci-fast.sh VM/compliance
Full AOT tail ./script/ci-local.sh --filter MiniWebAppAotExecuteTest LLVM required
Presenter bundle make north-star1-verify --require-llvm / --skip-llvm-tail

Show whether LLVM 9 is ready (same probe as ExamplesCompileTest) and whether loopback serve tests are skipped (PHP_COMPILER_SKIP_SERVE_TESTS).

Implementation hints

File Change
lib/Doctor.php New printNorthStar1PresenterSection()
bin/phpc.php No CLI flag change — reuse --gates
test/unit/DoctorGatesTest.php Assert substring north-star1-verify
docs/GETTING-STARTED.md Cross-link #1813 presenter script

Acceptance criteria

./phpc doctor --gates | grep -i north-star1-verify
./script/ci-fast.sh --filter DoctorGates

Dependencies

Verification

Local/Docker only — not GitHub Actions (#394 ✅).

Links

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions