Web: PATH_INFO and front-controller routing (#121)#133
Merged
Conversation
Derive PATH_INFO from REQUEST_URI minus SCRIPT_NAME in Superglobals, honor CGI PATH_INFO env, route /script.php/path in bin/serve.php, and add PHPT coverage for VM web tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$_SERVER['PATH_INFO']inSuperglobals::populateServer()by deriving fromREQUEST_URIminusSCRIPT_NAME, or from the CGIPATH_INFOenv var when setbin/serve.phpto route/index.php/foo/barto the script with PATH_INFO/foo/barweb_path_info.phptandweb_path_info_cgi_env.phptCloses #121
Test plan
vendor/bin/phpunit test/real/RealWorldTest.php— 34/34 passscript/ci-local.sh(full suite) on maintainer hostMade with Cursor