M2: deep JIT/VM helpers in lib spine smoke (#1056)#1421
Closed
PurHur wants to merge 1 commit into
Closed
Conversation
Add deep-wave JIT builtins and helpers to compiler_lib_spine_smoke with targeted AOT stubs and small lowering fixes for self-host parse/compile. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
Owner
Author
|
Superseded by #1454 (consolidated M2 spine merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler_lib_spine_smokewith deep-wave JIT builtins (StringParseStr,Type/Object_,Type/HashTable) and helpers (VarFetchHelper,UnsetHelper,ArrayBuiltinHelper,ReflectionBuiltinHelper,TypeCheck,ErrorHandlerCallbackPolicy);StringPregMatch/StringUnserializewere already on master.isSkippedLibSpineSmokeHotPathNamefor the new units.Object_,HashTable,VarFetchHelper, andArrayBuiltinHelper.BootstrapSelfhostBundleTestto 188 units (+9) and assert newLIB_SPINE_SMOKE_NEW_UNITS.Test plan
php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php./script/bootstrap-selfhost-lib-spine-smoke-link.sh(blocked here: missinglibffi.so.7/ LLVM FFI runtime)BootstrapSelfhostBundleTest::testCompilerLibSpineSmokeBundleUnitCountAndKeyUnits(count/key units)Made with Cursor