feat(lang): WeakReference / WeakMap VM stub (#1366)#1478
Merged
Conversation
This was referenced May 24, 2026
Register builtin WeakReference and WeakMap on the VM with create/get and ArrayAccess-style methods. WeakReference tracks targets via indirect slots so unset() clears get(); documented as partial until real GC weak refs exist. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
feat/lang-1366-weakref
branch
from
1af4e35 to
5b4dd01
Compare
Owner
Author
|
Rebased onto current Conflicts (4): Tests: Branch force-pushed: |
PurHur
force-pushed
the
feat/lang-1366-weakref
branch
from
f0ed728 to
f81adfc
Compare
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WeakReferenceandWeakMapso scripts no longer fatal with "class not found".WeakReference::create($obj)/get()use an indirect target slot:get()returns the object while alive andnullafterunset($obj)on the last strong variable (not cycle-collecting GC weak refs).WeakMapstub:offsetSet/offsetGet/offsetExists/offsetUnset/countwith object-id string keys; JIT external class registration for compile-only references.Test plan
php vendor/bin/phpunit test/unit/WeakReferenceWeakMapTest.php./script/ci-local.sh(if available in CI environment)Made with Cursor