M2 spine: push compiler_lib_spine_smoke to 300 units (#1056, #1419)#1479
Merged
Conversation
Add 16 lint-clean Vm* handlers and 9 stdlib wrapper units; fix intersection-type docblocks and TYPE_DECLARE_INTERFACE self-host JIT stub; resolve Compiler.php enum/interface merge; defer src shims that break bundled define() during AOT compile. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 24, 2026
PurHur
added a commit
that referenced
this pull request
May 24, 2026
…1056) (#1482) Remove phantom is_int/is_string requires that fall through to dynamic include opcodes, stub Compiler/AOT units during self-host AOT, and no-op TYPE_DECLARE_INTERFACE lowering so the 299-unit spine bundle links again. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
May 24, 2026
Guard cli.php vendor/autoload and argv driver when PHP_COMPILER_CLI_SPINE_BUNDLE=1, re-add src/ compat shims lost after #1479, and fix VM readonly docblock for php-types AOT lint. Spine grows 299→304 units; native link gate passes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler_lib_spine_smokefrom 280 → 300require_onceunits toward thebin/vm.phpinventory (🔄 North Star 2: Compiler fully compiles itself (living tracker) #1056).ext/standard/Vm*handler modules plus 9 stdlib wrapper units (floatval,hex2bin,addslashes,stripslashes,bin2hex,doubleval,is_int,is_string,pi).TYPE_DECLARE_INTERFACEJIT stub,Compiler.phpenum/interface conflict resolution,apply-patches.shpatch list merge, andvm_run_smokebootstrap-aot output parity.Gates
script/apply-patches.sh✅php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php✅vendor/bin/phpunit test/unit/BootstrapSelfhostBundleTest.php✅make bootstrap-aot-link✅ (71/71)BOOTSTRAP_LIB_SPINE_SMOKE=1 make bootstrap-selfhost-lib-spine-smoke— tracked in 🔄 North Star 2: Compiler fully compiles itself (living tracker) #1056 (wrapper units may need self-host stub follow-up)Test plan
Made with Cursor