CI: default MINIWEBAPP_SERVE_AOT_GATE=1 (#1524)#1532
Merged
Conversation
MiniWebAppServeAotTest is green (6/6); flip the gate default so full ci-local runs serve-aot HTTP integration without opt-in. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MINIWEBAPP_SERVE_AOT_GATEdefault from0to1inscript/ci-defaults.envso fullci-local.shrunsMiniWebAppServeAotTestwithout opt-in (CI: Default MINIWEBAPP_SERVE_AOT_GATE=1 — MiniWebAppServeAotTest in ci-local (#478, #610) #1524).ci-common.shfallback,CiScriptsTest,miniwebapp-gates.shstage ladder, and docs (development-status.md, unskip matrix).Test plan
./vendor/bin/phpunit --filter MiniWebAppServeAot— 6/6 green in Docker (php-compiler:22.04-dev)./vendor/bin/phpunit --filter testCiDefaultsEnvDefinesMiniWebAppAotGates— expects:-1./vendor/bin/phpunit --filter testMatrixDocListsAllIssueIds— matrix doc includesMINIWEBAPP_SERVE_AOT_GATEMINIWEBAPP_SERVE_AOT_GATE=0still skips via test gate logicCloses #1524
Made with Cursor