DevEx: root README north-star drift guard (#1832)#1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/check-root-readme-sync.phpto detect stale MiniWebApp execute wording in rootREADME.md(blocked AOT: MiniWebApp native binary CLI execute emits empty stdout (post-link) #764, execute partial, etc.) with line-numbered errors.ROOT_README_SYNC_GATE(default off) intoci-fast.shinventory checks,ci-defaults.env, Docker env, anddocs/local-ci-matrix.md.RootReadmeSyncTest(expects checker failure on current README until Docs: Sync North Star 1 status — README, #1044, development-status.md (#764 closed) #1525) andCiScriptsTestwiring assertions.Test plan
php script/check-root-readme-sync.php— fails with actionableREADME.md:<line>:errors on master README driftvendor/bin/phpunit --filter RootReadmeSyncTest(Docker, tar copy)vendor/bin/phpunit --filter 'testCi*RootReadme*|testLocalCiMatrixDocumentsRootReadmeSyncGate'ROOT_README_SYNC_GATEdefault to1and updateRootReadmeSyncTestto expect exit 0Closes #1832
Made with Cursor