Language: PHP 8 attributes VM v1 compliance pack (#1354, #1912)#1925
Merged
Conversation
Add compliance PHPTs and AttributeParseTest proving decorated class, method, and parameter declarations parse, lint clean, and execute with attributes ignored at runtime. Close wave-3 language track in roadmap-wave3.md. Regenerate bootstrap inventory (601 files) and sync M2 spine footnotes 589/601 for CI doc gates. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attribute_class,attribute_method,attribute_param) andAttributeParseTestproving PHP 8#[...]attributes on classes, methods, and parameters parse, lint clean, and run with attributes ignored at runtime (VM v1).docs/roadmap-wave3.md(12/12 done; JIT/AOT attribute reflection deferred).docs/bootstrap-inventory.md(601 files) and sync M2 spine footnotes 589/601 soci-fastdoc gates pass on harness hosts.Notes
No compiler changes required: host
php-parser+ php-cfg already accept decorated declarations; VM execution ignores attribute metadata. Out of scope:#[\Attribute]validation, enum targets, JIT/AOT reflection (#1904 gate can follow).Test plan
./script/docker-ci-local.sh fast(local Docker)vendor/bin/phpunit --filter attribute test/compliance/vendor/bin/phpunit test/unit/AttributeParseTest.phpCloses #1354
Closes #1912
Made with Cursor