CI: default-on INIT_FILEUPLOAD_PARITY_GATE in ci-fast (#2020)#2070
Merged
Conversation
Flip init-fileupload template parity to default-on after #2004 landed, matching INIT_SESSIONSWEB_PARITY_GATE and APIJSON_INIT_PARITY_GATE precedent. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INIT_FILEUPLOAD_PARITY_GATEdefault from0→1inscript/ci-defaults.envandci-common.shfallbackdocs/local-ci-matrix.md, template README, and examples/docs cross-linksCiScriptsTestassertions mirroring#2037/APIJSON_INIT_PARITY_GATEprecedentPrerequisite #2004 ✅ (
phpc init --profile fileupload+ parity checker).Test plan
docker-ci-local.sh fastinventory:check-init-fileupload-parity: OKwith default gate (no env override)INIT_FILEUPLOAD_PARITY_GATE=0still skips viaci_run_init_fileupload_parity_checkearly return./script/ci-local.shon LLVM harness before merge (contributor machine)make docker-build-22 ./script/docker-ci-local.sh fast --filter PhpcInitFileUpload INIT_FILEUPLOAD_PARITY_GATE=0 ./script/ci-fast.sh # skips 006 parity onlyCloses #2020
Made with Cursor