Web: Array query parameters for $_GET/$_POST (#200)#222
Merged
Conversation
Merge parse_str() output into VM superglobals for list and nested keys, resolve indirect containers in array dim fetch for chained access, and add unit/PHPT coverage for tags[]= and user[name]= style queries. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Superglobals::populateFormEncoded()to merge fullparse_str()output (list keys liketags[]=and nested keys likeuser[name]=).TYPE_ARRAY_DIM_FETCHso chained access ($_GET['user']['name']) works.Test plan
bash script/docker-ci.sh test/unit/Web/SuperglobalsArrayParamsTest.phpbash script/docker-ci.sh test/real/RealWorldTest.php(includesweb_get_array_params.phpt)bash script/docker-ci.sh— same 2 pre-existingnot_equal_identical*.phptVM failures as onmaster(Compiler: Not-identical and not-equal operators (!=, !==) parity in JIT #211 follow-up)Closes #200
Made with Cursor