Language: String offset access and assignment ($str[$i]) (#198)#233
Merged
Conversation
Add writable string byte offsets in the VM, LLVM JIT helpers for dim fetch/assign, and compliance PHPT cases for ASCII $str[$i] access. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$str[$i]dim-fetch returns an indirect string-byte lvalue; assignment mutates the parent string in place (Zend-compatible for ASCII bytes).StringOffsetHelpercompiles byte load/store via LLVM GEP; echo prints single-byte offsets with%c.string_offset.phptandstring_offset_jit.phpt.Closes #198.
Test plan
php bin/vm.php -r '$s="abc"; $s[1]="z"; echo $s;'→azcphp vendor/bin/phpunit test/compliance/VMTest.php(166 tests) inphp-compiler:22.04-devcontainer via tar pipetest/compliance/JITTest.php)Made with Cursor