Add phpc lint for unsupported syntax with line numbers (#236)#241
Merged
Conversation
Introduce LintCompiler/Linter that records CFG gaps instead of opaque LogicExceptions, wire bin/lint.php and phpc lint with --json, and document known unsupported constructs with tracking issue links. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LintCompiler/Linterthat records unsupported CFG nodes with file and line from php-cfg instead of throwing opaqueLogicExceptions.bin/lint.phpandphpc lintwith optional--jsonoutput and tracking-issue hints (loops Language: while, do-while, and for loops (CFG → VM → JIT) #192, foreach Language: Implement foreach (CFG → VM → JIT) #53,??Language: Null coalescing operator (??) in compiler pipeline #99, etc.).docs/unsupported-syntax.mdand addtest/unit/LintTest.php.Test plan
./phpc lint -r 'foreach ([1] as $x) {}'reports line +#53./phpc lint -r '$a = $b ?? 1;'reports#99./phpc lint -r 'echo "ok";'exits 0vendor/bin/phpunit test/unit/(Dockerphp-compiler:22.04-dev)Closes #236
Made with Cursor