Pre-install LLVM 9 in 22.04 dev Docker image#242
Merged
Conversation
Bake the bundled LLVM 9 toolchain into /opt/llvm9 at image build time so container CI finds JIT/AOT dependencies without re-downloading on every run. Resolve PHP_COMPILER_LLVM_PATH from bind-mounted .llvm, env, or /opt/llvm9. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/install-llvm9.shduringdocker buildinto/opt/llvm9withPHP_COMPILER_LLVM_PATHandLD_LIBRARY_PATHset in the image..llvm/,PHP_COMPILER_LLVM_PATH, or/opt/llvm9inphp-env.sh; skip redundant download inci-local.shwhen a toolchain is already present.make docker-build-22); add.dockerignoreto keep layers smaller.Closes #237.
Test plan
docker build -f Docker/dev/ubuntu-22.04/Dockerfile -t php-compiler:22.04-dev .LLVM 9 found at /opt/llvm9without runninginstall-llvm9.shdownload@group llvmtests execute in container (not 100% skipped)./script/docker-ci-local.shfull green (long-running on harness)Made with Cursor