Run HTTP serve integration tests in Docker local CI (#234)#251
Merged
Conversation
Probe loopback TCP bind in script/ci-local.sh, run @group serve after the VM suite, and document PHP_COMPILER_SKIP_SERVE_TESTS vs local verification. GitHub Actions keeps skipping serve tests; Docker and harness hosts must not. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
127.0.0.1TCP bind inscript/ci-local.sh(script/can-bind-loopback.php) and run@group serve(ServeTest,ServeAotTest) after the VM suite when allowed.PHP_COMPILER_SKIP_SERVE_TESTS=1only when loopback bind fails (unlessPHP_COMPILER_RUN_SERVE_TESTS=1).Closes #234
Test plan
script/can-bind-loopback.phpexits 0; ci-local printsLoopback TCP bind OK.vendor/bin/phpunit --group serveruns ServeTest/ServeAotTest (not skipped) withoutPHP_COMPILER_SKIP_SERVE_TESTS.PHP_COMPILER_SKIP_SERVE_TESTS=1, all serve tests skipped../script/docker-ci-local.shon a host with working bind-mount (long-running).Made with Cursor