M2 spine: complete Phase A coverage (716/717) (#2652)#2658
Merged
Conversation
Add the final 46 vm.php-path units (string/HTML builtins, reflection JIT helpers, emit-TU natives) to compiler_lib_spine_smoke. Extend php-types-union-type.patch so TypeReconstructor resolves Op\Type\Union_ (required for str_word_count / VmString::int|array return types). Restore lib/VM/HashTable.php as the single ratio-deferred spine path (#2543). Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_onceunits tocompiler_lib_spine_smoke(string/HTML ext + reflection JIT batch), reaching 716/717 Phase A coverage withlib/VM/HashTable.phpratio-deferred.php-types-union-type.patchsoTypeReconstructorhandlesOp\Type\Union_(unblocks spine lint forstr_word_count→VmString::int|array).Test plan
php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php./script/bootstrap-selfhost-lib-spine-smoke-link.sh(Docker)php script/check-selfhost-spine-coverage-sync.phpphp script/check-selfhost-spine-count-sync.phpphp script/check-selfhost-spine-deferred-sync.phpCloses #2652
Made with Cursor