Self-host M5: bin/compile.php AOT — literal include + LinkerProcessPolyfill lowering#2789
Merged
Merged
Conversation
…pile.php AOT bin/compile.php failed self-host AOT with a dynamic LinkerProcessPolyfill include and an unregistered LinkerProcessPolyfill::run static call. Use a literal require path (#54) and lower that call to the phpc_run_command builtin (#2779, #2697). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_once 'lib/AOT/LinkerProcessPolyfill.php'inbin/compile.phpso self-host AOT can fold the include (Language: include/require in JIT and AOT (multi-file applications) #54).lib/JIT.php, lowerLinkerProcessPolyfill::run()static calls to the existingphpc_run_commandAOT builtin during self-host AOT (Self-host M2/M5: shell_exec lowering for lib/AOT/Linker.php honest native link #2779).BootstrapAotJitCompileTestto guard the M5 driver compile path.Unblocks native AOT of
bin/compile.phpunderPHP_COMPILER_SELFHOST_AOT=1(was failing with dynamic-include / undefined-static-method errors; see #2697).Test plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && export PHP_COMPILER_SELFHOST_AOT=1 && php bin/compile.php -o /tmp/out bin/compile.php'→ exit 0, binary producedphpunit --filter testSelfHostAotBinCompilePhpCompiles test/unit/BootstrapAotJitCompileTest.phpPHP_COMPILER_M3_SOURCE=bin/compile.php ./script/bootstrap-selfhost-helloworld-compile-bin.sh→ compile OKmake bootstrap-selfhost-linkCloses #2697
Made with Cursor