Self-host: fix driver-smoke compiled helper + gate alias (#2769)#2801
Merged
Conversation
The self-host driver-smoke gate now builds the compiled bin/compile.php argv helper when missing and avoids routing the HelloWorld compile-driver link step through the bin/compile.php special-case. Also add BOOTSTRAP_M5_DRIVER_SMOKE_GATE alias wiring for CI/docs. Refs #2769 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootstrap-selfhost-driver-smokeso it always uses the HelloWorld compile-driver for gen-2, and builds the compiledbin/compile.phpargv helper only when needed.BOOTSTRAP_M5_DRIVER_SMOKE_GATEas an alias of the legacyBOOTSTRAP_M5_DRIVER_GATEand update docs.Test plan
./script/docker-exec.sh -- bash -lc 'make bootstrap-selfhost-driver-smoke'./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php vendor/bin/phpunit --filter BootstrapSelfhostDriverSmokeTest'Closes #2769
Made with Cursor