M4 gen-1 link: default inventory emit driver; gen-3 argv guard (#2893, #2890)#2902
Merged
Merged
Conversation
…#2890) Default bootstrap-loop-gen1-link to inventory compile_driver (no emit-helper TU), with helloworld bundle as the link TU and M3 compile-mode env at runtime. Map bootstrap_loop compile_driver to helloworld emit prefix in bin/compile.php; skip wrapper {main} for m3CompileDriverMainBlock. Add gen-3 recompile+emit stage to driver smoke to catch silent argv success. Closes #2893. Relates to #2890, #1492. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make bootstrap-loop-gen1-linkto inventorycompile_driver.phpemit (nocompile_smoke_m3_emit_native_entry.phpTU); bisect viaBOOTSTRAP_M3_EMIT_HELPER_TU=1.compiler_helloworld_smoke/compile_driver.phpas the inventory TU (bootstrap_loop wrapper is lint/M4 alias only); setPHP_COMPILER_M3_COMPILE_MODE=compileat runtime.bin/compile.php: treatbootstrap_loop_smoke/compile_driver.phplike helloworld forPHP_COMPILER_M3_EMIT_LOG_PREFIX.lib/JIT.php: do not use bootstrap_loop wrapper{main}asm3CompileDriverMainBlockwhen inventory emit is active.bootstrap-selfhost-driver-smoke.sh: stage 5 gen-3 recompile + argv emit/run (guards Self-host M4/M5: gen-3 bin/compile.php argv driver silent success (exit 0, no -o output) #2890 silent success).Verification
Closes #2893. Relates to #2890, #1492.
Test plan
make bootstrap-loop-gen1-link→emit_path=nativeBOOTSTRAP_M5_DRIVER_SMOKE=1 make bootstrap-selfhost-driver-smoke(gen-3 stage)make bootstrap-loop-probe-dry-runBootstrapBootstrapLoopProbeTest,BootstrapSelfhostDriverSmokeTestMade with Cursor