fix(m5): surface parseAndCompile failure text in native vendor invoker (#3037)#3084
Merged
Merged
Conversation
#3037) Record last parse/compile diagnostics in Runtime and echo them from the M3 emit LLVM bridge so native vendor compiles match Zend failure output. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime::getLastParseFailure()/peekLastParseFailure()to capture the last parse/compile diagnostic (exceptions and null-block returns).compile(),compileEmitSmoke(), andemitParseCompileFailureStderr(); clear on newparseAndCompile*runs.BootstrapCompileSmokeM3Emit) appends— {detail}on parseAndCompile null and records split parse+compile failures vianoteParseCompileNullForScript().bin/compile.php, compile driver, and bootstrap smoke scripts use the stored failure text instead of silent null.Closes #3037
php-src reference
N/A — self-host diagnostics (Zend parity is matching actionable
parseAndCompile failure:output from host PHP invoker).Test plan
./script/docker-exec.sh -- bash -lc './vendor/bin/phpunit test/unit/RuntimeAotLintTest.php --filter GetLastParseFailure'./script/docker-exec.sh -- bash -lc './vendor/bin/phpunit test/unit/BootstrapRuntimeCompileSmokeTest.php --filter testM3EmitTuRealLoweringSkipsEarlyParseStubDecl'./script/docker-exec.sh -- bash -lc 'make bootstrap-selfhost-helloworld'(optional M3 probe when LLVM available)Claim note
GitHub issue comment API returned 401 in this harness; branch
agent/issue-3037-parse-failure-diagnosticsclaims lane B issue #3037 for this run.Made with Cursor