fix(aot): stabilize explode() indexed string reads#318
Merged
Conversation
explode() PHPT failed intermittently with free(): invalid pointer when reading explode(...)[0] inline: the hashtable could be freed before __hashtable__readStringAt ran. Pin the table across readStringAt, return an owned copy via __string__separate, and separate before __value__writeString. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
free(): invalid pointerwhen AOT code usesexplode(...)[n](e.g. second line oftest/fixtures/aot/cases/explode.phpt).__hashtable__readStringAt, return an owned string via__string__separate, and copy before__value__writeStringso hashtable entries are never stolen.Root cause
Temporary
explode()hashtables could be freed before indexed string reads finished.__value__writeStringcould also take ownership of pointers still stored in the table.Test output (Docker
php-compiler:22.04-dev, LLVM at/opt/llvm9)(Baseline before fix: ~25–35% failure rate on the same stress loop.)
Test plan
php vendor/bin/phpunit test/aot/AotTest.phpin Dockerexplode.phptFILE section./script/docker-ci-local.shfull suite (recommended before merge)Made with Cursor