Language: foreach over Iterator / IteratorAggregate objects (#3234)#3245
Merged
Conversation
4 tasks
ab0c479 to
405a009
Compare
Merge Iterator protocol dispatch with object property foreach on master. Co-authored-by: Cursor <cursoragent@cursor.com>
405a009 to
86d06ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_ITER_*opcodes now drive userIterator/IteratorAggregateobjects viarewind()/valid()/current()/key()/next()(Zendzend_iterators.cparity).IteratorAggregate::getIterator()is resolved on reset; non-iterable objects raiseTypeErrorinstead ofLogicException.capabilities-syntax.md(VM-only; JIT deferred).php-src reference
Zend/zend_iterators.c— iterator helpersZend/zend_execute.c—ZEND_FE_RESET_R,ZEND_FE_FETCH_RTest plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter foreach_iterator'TypeErrorCloses #3234
Made with Cursor