DevEx: phpc.json schema and phpc validate-manifest (fixes #263)#390
Merged
Conversation
Machine-readable schema, ManifestValidator, and phpc validate-manifest catch unknown keys and missing binary paths before serve/build; phpc doctor warns when a repo-root manifest is invalid. Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/phpc-json.schema.jsondescribingbinary, optionalpublic, and stub fields (entry,includes,autoload.psr-4,index).PHPCompiler\Web\ManifestValidatorandphpc validate-manifest [dir]with actionable stderr messages.phpc doctorreports a non-blocking warning whenphpc.jsonexists at the repo root and fails validation.Test plan
vendor/bin/phpunit --filter ProjectManifestTest(6 tests) inphp-compiler:22.04-dev./script/docker-ci-local.sh --filter ProjectManifestTestecho '{"binary":"missing"}' > /tmp/phpc.json && phpc validate-manifest /tmp→ exit 1,binary path not foundCloses #263
Made with Cursor