ServeAotTest: PATH_INFO front-controller (closes #453)#456
Merged
Conversation
…e time Issue #453: mirror VM front-controller coverage under phpc serve --aot. Treat SCRIPT_NAME, PATH_INFO, PHP_SELF, and REQUEST_URI as runtime $_SERVER keys so AOT binaries reflect per-request CGI env instead of the compile host. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testServeAotPathInfoFrontControllerDispatchtoServeAotTest, mirroring VMServeTestcoverage from Testing: ServeTest PATH_INFO front-controller dispatch #276 forGET /index.php/hellounderphpc serve --aot.SuperglobalInit::RUNTIME_SERVER_KEYSwithSCRIPT_NAME,PATH_INFO,PHP_SELF, andREQUEST_URIso AOT no longer bakes compile-host CGI values into$_SERVERreads (fixes wrongSCRIPT_NAMEwhen compiling under PHPUnit).Test plan
vendor/bin/phpunit --filter testServeAotPathInfoFrontControllerDispatch test/real/ServeAotTest.php(Dockerphp-compiler:22.04-dev, tar copy)ServeAotTest(13 tests) green in DockerCloses #453
Made with Cursor