Fix $this in switch/if branches for MiniWebApp VM dispatch#516
Merged
Conversation
Inherit parent scope when compiling branch blocks and walk caller calledArgs so MiniWebApp Router dispatch runs under VM serve. Closes #210 (VM path). Adds switch_method_call compliance + unit test. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
switchcases,if/else, jumps) so branch blocks share slot indices with the enclosing method.$thisinBlock::getFrame()viacalledArgson ancestor frames, not only immediatecallArgs(fixes nestedswitchinRouter::dispatch()).PhpcLintProjectTestfor green003-MiniWebApplint; addswitch_method_callcompliance + unit coverage.Why
examples/003-MiniWebAppVM serve failed withCould not resolve argumentwhenRouter::dispatch()called private render methods fromswitchcases — blocking the reference web app path toward AOT (#210, #67).Test plan
./script/docker-ci-local.sh fast --filter 'SwitchMethodCallTest|PhpcLintProjectTest|MiniWebAppSkeleton'php bin/vm.phpon003-MiniWebAppdispatch('GET','home')returns HTML./script/ci-local.shon merge host (LLVM)Closes #210
Made with Cursor