Bootstrap Phase C: AOT link and native execute gate#517
Merged
Conversation
Introduce script/bootstrap-aot-link.sh and Makefile target to compile aot_link_targets from the bootstrap profile, run native binaries, and compare stdout to Zend PHP. Wire optional --link on bootstrap-aot-lint and add PHPUnit coverage for echo_hello and the link script. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/bootstrap-aot-link.shandmake bootstrap-aot-linkto compile eachaot_link_targetsentry fromdocs/bootstrap-profile.json, run the native binary, and assert stdout matches Zend PHP.aot_link_targets(lint superset minusnullable_types.phpuntil user-function AOT is ready).test/aot/BootstrapPhaseCTest.php(@group bootstrap,aot-link) and document Phase C indocs/bootstrap-selfhost.md; optionalphp script/bootstrap-aot-lint.php --link.Closes #512
Test plan
docker run --rm -m 10g -v $(pwd):/compiler -w /compiler -e PHP_COMPILER_MEMORY_LIMIT=4096M php-compiler:22.04-dev ./script/bootstrap-aot-link.shdocker run ... vendor/bin/phpunit test/aot/BootstrapPhaseCTest.phpMade with Cursor