Bootstrap AOT: minimal namespace support (closes #513)#518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PHPCfg\Op\Expr\NsFuncCallusing the fully-qualifiednsNameoperand for function lookup (definitions already usenamespacedNamefrom php-cfg).patches/php-types-ns-func-call.patchsoTypeReconstructorresolves namespaced calls.test/bootstrap-aot/namespace_hello.phpand register it in the bootstrap profile / AOT lint ladder.Progresses #513 (self-host namespace gate) and #84 (PHP namespaces). Single file, single namespace, no
useimports.Test plan
docker run --rm -m 10g -v $(pwd):/compiler -w /compiler php-compiler:22.04-dev bash -c 'source script/ci-defaults.env && php bin/compile.php -l test/bootstrap-aot/namespace_hello.php'php script/bootstrap-aot-lint.php(6 targets)Still blocking full
lib/self-host (#84)use/ import aliases and multi-file PSR-4 autoloadnamespaceblocks without hoisted functionslib/*.phpunits that mix namespaces with classes, traits, etc.Closes #513
Refs #84
Made with Cursor