AOT: PHPC_DEPLOY_ROOT for deployed template paths (#585)#592
Merged
Conversation
Add phpc_deploy_path() (VM + JIT/AOT) and rewrite bundled __DIR__ against project root so relocated binaries resolve paths under PHPC_DEPLOY_ROOT. Includes DeployRootTest AOT smoke and SourceBundler project-root wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate bootstrap inventory/profile after conflict resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpc_deploy_path($relFromProjectRoot, $fallbackAbsoluteDir)to stdlib (VM + JIT/AOT) readingPHPC_DEPLOY_ROOTat runtime.phpc build --projectbundles sources, rewrite__DIR__tophpc_deploy_path(...)using paths relative to the project root.DeployRootTest(AOT link) proving a binary run from a non-source cwd resolves paths underPHPC_DEPLOY_ROOT.Test plan
vendor/bin/phpunit --group aot-link --filter DeployRootTest(Docker)vendor/bin/phpunit --filter DeployRoot(VM unit tests)script/ci-fast.shcapability/bootstrap checksCloses #585.
Made with Cursor