phpc deploy: bundle binary, public/, assets/, phpc.json into dist/#615
Merged
Conversation
Add ProjectDeploy and `phpc deploy -o` to copy bin/app, phpc.json, public/, assets/, templates/, and README.deploy with path traversal checks. Builds the project binary first unless --from-build is set. Fixes #609 Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/Web/ProjectDeployto copy AOT binary →bin/app,phpc.json, optionalpublic/,assets/,templates/, andREADME.deploywith traversal-safe path checks.phpc deploy [dir] -o <dist> [--from-build]inbin/phpc.php; runsphpc build --projectwhen the binary is missing.test/unit/PhpcDeployTest.php(copy-only fixture + CLI smoke whenexamples/002-StaticWebbinary exists).Test plan
php vendor/bin/phpunit --filter PhpcDeployTest(Docker tar pipe)./phpc deploy examples/002-StaticWeb -o /tmp/static-dist --from-buildafter build (Docker)PhpcCliTesthelp listsphpc deployFixes #609
Made with Cursor