Reject #[\Override] on trait-provided methods at compile time (#6440)#6477
Merged
Conversation
Trait-composed methods are not valid override targets in php-src; only parent class and interface methods count. Removes trait lookup from OverrideValidator/ClassCompileRegistry and adds compliance guards. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[\Override]no longer treats trait-composed methods as valid override targets — matches php-srczend_compile.c(parent class + interface chain only).ClassCompileRegistry::hasOverridableMethod()/findOverriddenMethod()and simplifiedOverrideValidator.Closes #6440
php-src reference
Zend/zend_compile.c—ZEND_ACC_OVERRIDEvalidation walks parent class chain only; trait methods are not override targets (PHP 8.3+)Verification
Issue repro (compile-time fatal, exit 255):
Made with Cursor