JIT: per-run superglobal refresh for bin/jit.php (#642)#653
Merged
Conversation
Sync MCJIT sg_* tables from the VM before each bin/jit.php run, export -q/-p into CGI env, and skip compile-time superglobal folding in embed mode so back-to-back invocations and repeated runs see fresh $_REQUEST data. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-q/-pintoQUERY_STRING/REQUEST_BODYCGI env viaSuperglobals::exportCgiEnvironment().bin/jit.phprun,Runtime::syncJitSuperglobals()repopulates the VM and re-runs JIT__init__sosg_*tables match the current request without recompiling LLVM IR.Test plan
vendor/bin/phpunit --filter SuperglobalsExportCgiTest(Docker tar pipe)vendor/bin/phpunit --filter JitSuperglobalRefreshTest(requires working MCJIT; harness currently segfaults onjit-runtime-probe— same onmaster)php bin/jit.php -q 'name=Alice' examples/001-SimpleWeb/example.phpthen BobCloses #642
Made with Cursor