DevEx: make examples-aot-smoke — phpc build + execute for 001-004 (#667)#669
Merged
Conversation
…667) Adds script/examples-aot-smoke.sh to build 000–004 under .phpc/smoke/ and assert stdout needles (001 uses QUERY_STRING=name=Smoke). Skips gracefully without LLVM; 003 documented as blocked on #568. Optional ci-local gate via EXAMPLES_AOT_SMOKE_GATE=1. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/examples-aot-smoke.shandmake examples-aot-smoketo build shipped examples 000–004 under.phpc/smoke/and assert CLI stdout needles (no HTTP).QUERY_STRING=name=Smoke; 003-MiniWebApp is documented as skipped until AOT: Native user-class object model for phpc build --project #568/Testing: MiniWebApp AOT binary CLI execute smoke (tracked in #747, blocked #764) #485.PHP_COMPILER_LLVM_PATH(no silent fallback when set but invalid). OptionalEXAMPLES_AOT_SMOKE_GATE=1hook inci-local.sh(default off).ExamplesAotSmokeScriptTest+CiScriptsTestcoverage; docs inexamples/README.mdand root README.Closes #667.
Test plan
docker run … php-compiler:22.04-dev ./script/examples-aot-smoke.sh— all four examples okvendor/bin/phpunit --filter ExamplesAotSmokeScriptTestin DockerCiScriptsTestgate assertionsMade with Cursor