Docs: add 003-MiniWebApp to examples benchmark table (#491)#685
Merged
Conversation
When MiniWebApp lint is green (or BENCH_MINIWEBAPP=1), rebuild-examples benchmarks public/index.php with PATH_INFO=/home; AOT columns stay n/a until phpc build --project link (#568). Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/rebuild-examples.phpto benchmarkexamples/003-MiniWebApp/public/index.phpwhenphpc lint --allpasses (orBENCH_MINIWEBAPP=1), usingPATH_INFO=/homeCGI env for native/VM/JIT columns.phpc build --projectlink is green (AOT: Native user-class object model for phpc build --project #568).examples/README.mdbenchmark table (003 row between 002 and 004) and document the gate in the Benchmark results section.Test plan
MINIWEBAPP_LINT_GATE=1 php script/rebuild-examples.phpin Docker (with.llvmfor other examples)vendor/bin/phpunit --filter PHPCompiler\\RebuildExamplesTest./script/docker-ci-local.sh fast(default gates)Closes #491
Made with Cursor