Fix interface property hooks satisfied by plain typed properties (#7311)#7335
Merged
Merged
Conversation
…).
Zend 8.4 allows implementing classes to satisfy interface { get; } / { get; set; }
obligations with ordinary typed properties. Sanitize inherited hook metadata at
class link time and treat backing fields as implicit hook providers in compile-time
and runtime abstract-hook checks.
Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ get; }/{ get; set; }obligations (zend_property_hooks.c parity)inheritInterfacePropertyHooks/inheritParentPropertyHooksstrip abstract/virtual hook metadata when a backing field implements the obligationInterfaceImplementationCheck) and runtime (AbstractPropertyHookCheck) treat declared backing fields as implicit get/set providersCloses #7311
php-src reference
Zend/zend_compile.c— interface property hook validationZend/zend_property_hooks.c— backing-field satisfactionVerification
Made with Cursor