VmFsUnlink/VmFsGlob: bootstrap without ext/ffi (#7314)#7378
Merged
Conversation
Route VM unlink/glob through host libc when FFI is disabled or unavailable, matching the JIT/AOT native paths. Adds PHP_COMPILER_DISABLE_FFI gate and compliance/unit coverage for bootstrap temp-file cleanup. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/ffiis unavailable orPHP_COMPILER_DISABLE_FFI=1, fall back to host@unlink()instead of returningfalsesilently — fixes bootstrap temp-file cleanup (php-in-php: VmFsGlob/VmFsUnlink — delete host ext/ffi glob(3)/unlink(2) shims (bootstrap self-host) #7314, Bootstrap: VmFs::unlink() — libc unlink(2) without host @unlink (ext/standard/filestat.c) #5063).\glob()path between libc FFI and pure-PHP iterator fallback; respectPHP_COMPILER_DISABLE_FFI.unlink_bootstrap.phpt,VmFsUnlinkBootstrapTest(FFI disabled via env).C runtime: no new C; VM no longer requires
FFI::cdeffor unlink/glob on the Zend driver. JIT/AOT unchanged (JitUnlink/__phpc_glob_vec).php-src reference
ext/standard/filestat.c—php_unlinkext/standard/dir.c—PHP_FUNCTION(glob)Verification
Closes #7314
Made with Cursor