Skip to content

AOT: deploy-include PHPTs + skip MiniWebApp link until #568#760

Merged
PurHur merged 1 commit into
masterfrom
aot/deploy-include-phpt-and-568-skip
May 23, 2026
Merged

AOT: deploy-include PHPTs + skip MiniWebApp link until #568#760
PurHur merged 1 commit into
masterfrom
aot/deploy-include-phpt-and-568-skip

Conversation

@PurHur
Copy link
Copy Markdown
Owner

@PurHur PurHur commented May 23, 2026

Summary

  • Add two AOT link PHPT fixtures (deploy_include_fallback, deploy_include_runtime) that compile deploy_include_template/entry.php with bin/compile.php and run the native binary — covering phpc_deploy_path() fallback vs PHPC_DEPLOY_ROOT runtime resolution (AOT: Runtime include() of deploy-root PHP via phpc_deploy_path() #623).
  • Fix the deploy-include fixture entry to use the templates directory as fallback (…/templates + /marker.php).
  • Skip ExamplesCompileTest::test003MiniWebAppEventuallyRuns and PhpcBuildProjectTest::testMiniWebAppBuildLinksNativeBinary when PhpcBuild::isUserClassAotBlocked() so @group aot-link CI is green while AOT: Native user-class object model for phpc build --project #568 is open.

Test plan (Docker php-compiler:22.04-dev, tar copy — bind-mount empty on harness)

tar -cf - --exclude='.git' --exclude='.llvm' . | docker run --rm -i -m 10g -w /compiler php-compiler:22.04-dev bash -c '
  tar -xf - && vendor/bin/phpunit --filter deploy_include
'
# OK (2 tests, 12 assertions)

tar -cf - --exclude='.git' --exclude='.llvm' . | docker run --rm -i -m 10g -w /compiler php-compiler:22.04-dev bash -c '
  tar -xf - && vendor/bin/phpunit --group aot-link --exclude-group serve
'
# OK (189 tests, 1017 assertions, 1 skipped — 003-MiniWebApp #568)

tar -cf - --exclude='.git' --exclude='.llvm' . | docker run --rm -i -m 10g -w /compiler php-compiler:22.04-dev bash -c '
  tar -xf - && vendor/bin/phpunit --filter ExamplesCompileTest
'
# OK (36 tests, 1 skipped)

Full gate: ./script/docker-ci-local.sh (LLVM phases include the above).

Made with Cursor

- Link/execute phpc_deploy_path() fallback and PHPC_DEPLOY_ROOT paths via
  bin/compile.php (deploy_include_* PHPT fixtures).
- Correct deploy_include_template entry path (templates dir + /marker.php).
- Skip ExamplesCompileTest and PhpcBuildProjectTest MiniWebApp native build
  when PhpcBuild::isUserClassAotBlocked() so aot-link CI stays green.

Docker: vendor/bin/phpunit --group aot-link --exclude-group serve
→ OK (189 tests, 1 skipped for #568).

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant