AOT: deploy-include PHPTs + skip MiniWebApp link until #568#760
Merged
Conversation
- Link/execute phpc_deploy_path() fallback and PHPC_DEPLOY_ROOT paths via bin/compile.php (deploy_include_* PHPT fixtures). - Correct deploy_include_template entry path (templates dir + /marker.php). - Skip ExamplesCompileTest and PhpcBuildProjectTest MiniWebApp native build when PhpcBuild::isUserClassAotBlocked() so aot-link CI stays green. Docker: vendor/bin/phpunit --group aot-link --exclude-group serve → OK (189 tests, 1 skipped for #568). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy_include_fallback,deploy_include_runtime) that compiledeploy_include_template/entry.phpwithbin/compile.phpand run the native binary — coveringphpc_deploy_path()fallback vsPHPC_DEPLOY_ROOTruntime resolution (AOT: Runtime include() of deploy-root PHP via phpc_deploy_path() #623).…/templates+/marker.php).ExamplesCompileTest::test003MiniWebAppEventuallyRunsandPhpcBuildProjectTest::testMiniWebAppBuildLinksNativeBinarywhenPhpcBuild::isUserClassAotBlocked()so@group aot-linkCI is green while AOT: Native user-class object model for phpc build --project #568 is open.Test plan (Docker
php-compiler:22.04-dev, tar copy — bind-mount empty on harness)Full gate:
./script/docker-ci-local.sh(LLVM phases include the above).Made with Cursor