Constructor dependency injection#44
Merged
Merged
Conversation
Collaborator
Author
|
I've deployed this to staging and everything appears to work as expected. @skkra0 Can you test authentication with your local Rancher setup to make sure I didn't break it? |
Collaborator
|
It works with local Rancher OIDC. If it works on staging then should be good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves service functions into their own classes. Each class accepts its dependencies as constructor parameters and stores them as properties, which will make the system easier to test by providing mock dependencies that don't need to interact with external systems.
This PR does not address iffy boundaries and tight connections between services. They existed before and still do, but this PR may make them easier to see.
There should be no differences in functionality before vs. after this PR is merged. These are purely structural changes.