Conversation
jfversluis
force-pushed
the
fix/close-session-now-has-a-trash-basket-as-20260220-1605
branch
from
e281415 to
91a3df9
Compare
The 🗑 (wastebasket) emoji on the Close Session button implied permanent deletion, but closing a session is a reversible action. Replace it with ✕ (multiplication sign) which better conveys 'close/dismiss' semantics. Changed in both SessionCard.razor and SessionListItem.razor. The trash icon is still used for actual destructive actions (Remove Repo, Delete Group) where it remains appropriate. Added CloseSessionIconTests to prevent regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jfversluis
force-pushed
the
fix/close-session-now-has-a-trash-basket-as-20260220-1605
branch
from
255bf35 to
f3e3566
Compare
PureWeen
deleted the
fix/close-session-now-has-a-trash-basket-as-20260220-1605
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Close Session button used a 🗑 (wastebasket/trash) emoji icon, which implies permanent deletion. However, closing a session is a reversible action — the session can be restored later.
Fix
Replaced the 🗑 icon with ✕ (multiplication sign/close mark) in both:
SessionCard.razor(Dashboard card context menu)SessionListItem.razor(Sidebar session list context menu)The trash icon is still used for actual destructive actions (Remove Repo, Delete Group) where it remains appropriate.
Tests
Added
CloseSessionIconTests.cswith 4 tests to prevent regression:All 688 tests pass. Mac Catalyst build succeeds.