Update PR Review Squad config with operational knowledge#220
Merged
Conversation
Update the built-in PR Review Squad preset with fix process, re-review patterns, orchestrator responsibilities, and operational lessons learned from 15+ PR review/fix cycles. Revert .squad/ to original state since the built-in preset is the canonical source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
force-pushed
the
squad/update-pr-review-squad-config
branch
from
c3b29e9 to
a41d6ac
Compare
Replace repo-specific test command with generic discovery instruction so the preset works across any GitHub repository, not just PolyPilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
RepoManager.GetBaseDir() resolved to the real ~/.polypilot/ directory during test runs, so tests creating new RepoManager() instances could overwrite repos.json with test data (repo-1/MyRepo), destroying the user's registered repositories. Add SetBaseDirForTesting() to RepoManager (matching the existing CopilotService pattern) and call it from TestSetup.Initialize(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ctory Delete repo-level .squad/PR-Review-Squad so it no longer shadows the built-in preset in the Multi dropdown. The operational knowledge is now in the built-in preset in ModelCapabilities.cs. Also fix WorkingDirectory not being set in demo mode CreateSessionAsync, which caused WorktreeStrategyTests.Shared_WithRepoButNoWorkDir to fail. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Worker rules and routing context now adapt based on worktree strategy: shared worktrees prevent checkout during reviews, isolated worktrees allow free checkout - Review synthesis now includes test coverage assessment: suggests specific test cases or scenarios for new code paths Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ensure memory ordering on ARM64: after the release write to _baseDirOverride, the null assignments to _reposDir/_worktreesDir/_stateFile are now also volatile writes so concurrent readers cannot observe the new override with a stale cached path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
.squad/team definition with operational knowledge accumulated from 15+ PR review/fix cycles.Changes
routing.mddecisions.mdagents/reviewer-*/charter.md(all 5)Why
A fresh PR Review Squad created from this
.squad/definition will now inherit all process knowledge, making it immediately effective without needing to re-learn operational patterns.