Fix close session dialog not respecting theme#233
Merged
StephaneDelcroix merged 2 commits intomainfrom Feb 28, 2026
Merged
Conversation
Replace hardcoded dark-theme colors in the JS-rendered close session dialog with CSS theme variables so it looks correct in all themes (polypilot-light, solarized-light, solarized-dark, etc.): - background: #2a2a3e → var(--bg-secondary) - border: rgba(124,92,252,0.6) → var(--border-accent) - box-shadow: hardcoded purple → var(--border-accent) - title color: #fff → var(--text-bright) - close button: #ff6b6b → var(--accent-error) Add regression tests to verify the dialog CSS uses theme variables. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Change color: #fff to color: var(--text-bright) on .js-close-dialog-btn for consistent theming and better contrast in light themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
StephaneDelcroix
force-pushed
the
fix/the-close-session-dialog-is-not-themed-20260227-0735
branch
from
b559291 to
dbd3da3
Compare
Collaborator
Author
✅ Multi-Model Review: Ready to Merge5-model consensus review found one issue —
Post-fix re-review (5 models): All confirmed the fix. No remaining consensus issues. All CSS variables ( |
StephaneDelcroix
deleted the
fix/the-close-session-dialog-is-not-themed-20260227-0735
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The close session confirmation dialog used hardcoded dark-theme colors instead of CSS theme variables, making it look wrong in light themes.
Fix
Replace hardcoded colors with theme variables in
app.css:background: #2a2a3e→var(--bg-secondary)border: rgba(124,92,252,...)→var(--border-accent)box-shadow: removed hardcoded purple glow, usesvar(--border-accent)title color: #fff→var(--text-bright)close button: #ff6b6b→var(--accent-error)Tests
Added
CloseDialogThemeTests.cs(5 tests) that scanapp.cssto verify the dialog styles use theme variables and don't contain hardcoded colors.