feat: make Log label clickable to show session event log popup#237
Merged
StephaneDelcroix merged 2 commits intomainfrom Feb 28, 2026
Merged
Conversation
The 'Log' label in the ExpandedSessionView status bar was a static span with no click handler. This makes it clickable to show a popup with the session's event log (parsed from events.jsonl), following the same popup pattern used by skills/agents/prompts triggers. Changes: - Add ParseEventLogFile() and GetEventDetail() to CopilotService.Utilities for reading and summarizing events.jsonl entries - Add ShowLogPopup() click handler to ExpandedSessionView with JS popup - Style .log-label with cursor:pointer and accent color (like .skills-trigger) - Add 16 unit tests covering event parsing, truncation, malformed input, and razor markup verification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Wrap file I/O in Task.Run for async execution (Issue A) - Cap parsed events at 500 entries (Issue B) - Fix event count mismatch: use filtered.Count not entries.Count (Issue C) - Scope querySelector to session-unique data-trigger (Issue D) - Escape Unicode line terminators in EscapeForJs (Issue E) - Update test to match new session-scoped data-trigger pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
StephaneDelcroix
force-pushed
the
fix/theres-a-log-label-at-screens-bottom-its-20260227-0919
branch
from
3d4a87e to
2b9ceb4
Compare
Collaborator
Author
✅ Multi-Model Review: Ready to MergeInitial 5-model review found 5 issues. All fixed in follow-up commit
Post-fix re-review (5 models): All 5 issues confirmed fixed. No new consensus issues. Tests: 1569/1570 pass (1 pre-existing locale failure unrelated). |
StephaneDelcroix
deleted the
fix/theres-a-log-label-at-screens-bottom-its-20260227-0919
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 'Log' label in the ExpandedSessionView status bar was a static
<span>with no click handler — clicking it did nothing. This PR makes it clickable to show a popup with the session's event log (parsed fromevents.jsonl).Changes
ParseEventLogFile()(internal static, testable) andGetEventDetail()methods to read and summarize events.jsonl entries. Returns compact (timestamp, eventType, detail) tuples.@onclick="ShowLogPopup"anddata-trigger="log"to the Log label. AddedShowLogPopup()method using the same JS popup pattern as skills/agents/prompts..log-labelwithcursor: pointerand accent color (same as.skills-trigger).What it looks like
Clicking 'Log' shows a compact event log popup with color-coded event types:
The popup follows the same overlay pattern as skills/agents/prompts and auto-scrolls for long sessions.