Merged
Conversation
- CopilotService.cs: Fix CS0126 build error — bare `return;` in CreateSessionAsync which returns Task<AgentSessionInfo>. Changed to `return info;` for the early-exit path when a session is closed during SDK creation. - PlatformHelperTests.cs: Update AvailableModes_OnNonDesktop test to account for Demo mode being available in DEBUG builds. The PlatformHelper was updated to include Demo on non-desktop in DEBUG but the test was not updated to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues preventing the test suite from passing:
1. Build error in CopilotService.cs (CS0126)
CreateSessionAsyncreturnsTask<AgentSessionInfo>but had a barereturn;on the early-exit path (when a session is closed during SDK creation). Changed toreturn info;.2. Failing test:
AvailableModes_OnNonDesktop_IsRemoteOnlyPlatformHelper.AvailableModeswas updated to includeDemomode on non-desktop in DEBUG builds, but the test still assertedAssert.Single(). Updated the test to expect[Remote, Demo]in DEBUG and[Remote]in Release.Verification
All 1700 tests pass after these changes (run twice to confirm no flakiness).