fix: isolate PromptLibraryService from real filesystem in tests#277
Merged
fix: isolate PromptLibraryService from real filesystem in tests#277
Conversation
- Add PromptLibraryService.SetUserPromptsDirForTesting() to TestSetup module
initializer so tests never read from real ~/.polypilot/prompts/
- Add [Collection("PromptLibrary")] to PromptCommandTests and PromptLibraryTests
to serialize them and prevent parallel mutation of the static _userPromptsDir
- Add PromptLibraryCollection.cs with the CollectionDefinition
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #272.
Fixes a test isolation gap where
PromptLibraryServicecould read/write the real~/.polypilot/prompts/directory during tests, and a parallel race betweenPromptCommandTestsandPromptLibraryTestscausing flaky failures.Changes:
PromptLibraryService.SetUserPromptsDirForTesting()toTestSetupmodule initializer so tests always start with an isolated temp dir (matches the pattern forCopilotServiceandRepoManager)[Collection("PromptLibrary")]to bothPromptCommandTestsandPromptLibraryTeststo prevent parallel mutation of the process-global_userPromptsDirstatic fieldPromptLibraryCollection.cswith the[CollectionDefinition]Without this fix, tests that access
PromptLibraryService.UserPromptsDirbefore an explicitSetUserPromptsDirForTestingcall resolve to the real filesystem path.