fix: correct originalPrompt parameter in reflect loop exit drain#281
Merged
fix: correct originalPrompt parameter in reflect loop exit drain#281
Conversation
The exit drain in SendViaOrchestratorReflectAsync was passing the outer `prompt` as originalPrompt instead of `leftover`, misattributing the response in chat history. Follow-up to PR #275. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen
force-pushed
the
fix/orchestrator-exit-drain-original-prompt
branch
from
568f971 to
2322c8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #275. The exit drain in
SendViaOrchestratorReflectAsyncpassesoriginalPrompt: prompt(the outer loop prompt) instead oforiginalPrompt: leftover(the actual message being sent). This causes the response to be misattributed in chat history — the user sees their queued message associated with the wrong original input.One-line fix identified in Round 6 review (R6-N1).