fix: widen ReconnectState test window to fix CI failure#321
Merged
Conversation
…uccessfulToolCountThisTurn The ReconnectState_ShouldCarryIsMultiAgentSession test scans CopilotService.cs source to verify IsMultiAgentSession is carried forward near HasUsedToolsThisTurn in the reconnect block. The 200-char search window was too narrow after SuccessfulToolCountThisTurn was added between them, causing CI failure. Widened to 400 chars. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Failure
ReconnectState_ShouldCarryIsMultiAgentSessionfails in CI (run) with:Root Cause
This source-scanning test checks that
IsMultiAgentSessionis carried forward nearHasUsedToolsThisTurnin the reconnect block ofSendPromptAsync. The test uses a 200-char search window, but theSuccessfulToolCountThisTurncarry-forward line (added in a later PR between the two) pushedIsMultiAgentSessionbeyond that window.The production code is correct —
IsMultiAgentSessionIS properly carried forward at line 2471.Fix
Widened the search window from 200 → 400 chars to accommodate intermediate carry-forward lines.
All 2279 tests pass.