Conversation
…r prompts Workers in multi-agent orchestration could fabricate results when CLI tools failed to run, instead of reporting the failure. This adds explicit instructions across all orchestration prompt paths: - Worker prompt: CRITICAL tool usage policy requiring actual tool execution, honest failure reporting, and TOOL_FAILURE sentinel for unrecoverable errors - Synthesis prompt: Instructions to flag fabricated results and preserve TOOL_FAILURE reports as-is without guessing missing results - Evaluator prompts (both multi-agent and reflection cycle): New 'Tool Verification' scoring dimension that penalizes results lacking evidence of actual tool execution - Synthesis-with-eval prompt: Tool Verification assessment dimension Includes 7 unit tests covering all modified prompt paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The test was constructing its own string and asserting against it, providing no real regression protection. Now extracts the prompt building into a BuildWorkerPrompt static method and tests it via reflection, matching the pattern of the other 6 tests in the file. Co-authored-by: GitHub Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workers in multi-agent orchestration could fabricate results when their CLI tools failed to run, instead of honestly reporting the failure. The user expectation is: if tools don't run, workers should fail and report that — never fall back to self-evaluation or making up results.
Root Cause
Three prompt construction paths lacked tool-usage honesty instructions:
ExecuteWorkerAsync): No instruction about tool failuresBuildSynthesisPrompt): No guidance to verify tool usage in worker outputsBuildEvaluatorPromptpaths): No tool-verification scoring dimensionFix
CRITICAL: Tool Usage & Honesty Policysection requiring actual tool execution, honest failure reporting, andTOOL_FAILUREsentinel for unrecoverable errorsTOOL_FAILUREreports as-isTool Verificationas a 5th scoring dimension (multi-agent evaluator) and verification check (reflection cycle evaluator)Tool Verificationassessment dimensionTests
Added 7 unit tests in
WorkerToolHonestyTests.cscovering all modified prompt paths:All 2544 passing tests continue to pass (4 pre-existing font-sizing failures unrelated).