Skip to content

Fix ExternalSessionScanner cache thread safety #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Mar 18, 2026
+2 −2
Merged

Fix ExternalSessionScanner cache thread safety #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PolyPilot/Services/ExternalSessionScanner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class ExternalSessionScanner : IDisposable
private volatile bool _disposed;

// Cache: sessionId -> (eventsFileMtime, parsedInfo)
private readonly Dictionary<string, (DateTimeOffset mtime, ExternalSessionInfo info)> _cache = new();
private readonly System.Collections.Concurrent.ConcurrentDictionary<string, (DateTimeOffset mtime, ExternalSessionInfo info)> _cache = new();

private static readonly TimeSpan ActiveThreshold = TimeSpan.FromMinutes(2);
private static readonly TimeSpan IdleThreshold = TimeSpan.FromHours(4);
Expand Down Expand Up @@ -283,7 +283,7 @@ internal void Scan()

// Evict cache entries for sessions no longer live
var staleKeys = _cache.Keys.Where(k => !seenIds.Contains(k)).ToList();
foreach (var k in staleKeys) _cache.Remove(k);
foreach (var k in staleKeys) _cache.TryRemove(k, out _);

// Sort by recency
newSessions.Sort((a, b) => b.LastEventTime.CompareTo(a.LastEventTime));
Expand Down