fix: flaky ProcessHelper test catches leaked exceptions from other tests#454
Merged
fix: flaky ProcessHelper test catches leaked exceptions from other tests#454
Conversation
SafeHasExited_ConcurrentDispose_NoUnobservedTaskException subscribed
to TaskScheduler.UnobservedTaskException globally and matched ALL
InvalidOperationExceptions. A leaked task from StubChatDatabase
('DB connection failed') triggered the handler, causing a false
failure.
Fix: filter to only process-related IOE messages (process, exited,
handle) so unrelated test pollution is ignored.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
arisng
pushed a commit
to arisng/PolyPilot
that referenced
this pull request
Apr 4, 2026
…sts (PureWeen#454) ## Problem `SafeHasExited_ConcurrentDispose_NoUnobservedTaskException` subscribes to `TaskScheduler.UnobservedTaskException` globally and catches **all** `InvalidOperationException`s. A leaked unobserved task from `StubChatDatabase` (`DB connection failed`) triggers the handler, causing a false test failure. This caused the v1.0.15 release build to fail: https://github.com/PureWeen/PolyPilot/actions/runs/23745086209/job/69171558724 ## Fix Filter the handler to only match process-related `InvalidOperationException` messages (containing `process`, `exited`, or `handle`) so unrelated test pollution is ignored. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SafeHasExited_ConcurrentDispose_NoUnobservedTaskExceptionsubscribes toTaskScheduler.UnobservedTaskExceptionglobally and catches allInvalidOperationExceptions. A leaked unobserved task fromStubChatDatabase(DB connection failed) triggers the handler, causing a false test failure.This caused the v1.0.15 release build to fail: https://github.com/PureWeen/PolyPilot/actions/runs/23745086209/job/69171558724
Fix
Filter the handler to only match process-related
InvalidOperationExceptionmessages (containingprocess,exited, orhandle) so unrelated test pollution is ignored.