fix: update Mac Catalyst publish job to Xcode 26.3#652
Conversation
PR #649 updated the Build & Test job but missed the Publish Mac Catalyst App job, which still hardcoded Xcode 26.2. The .NET MacCatalyst SDK 26.2.10233 requires Xcode 26.3, causing all Mac Catalyst builds to fail. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔍 Pre-existing Design ObservationsThese are not introduced by this PR. Noted for follow-up consideration.
|
There was a problem hiding this comment.
Expert Code Review — PR #652
✅ Verdict: Looks good
Methodology: 3 independent reviewers with adversarial consensus (findings require 2/3+ agreement to be included).
Change Summary
Updates the "Publish Mac Catalyst App" job's Xcode selection from 26.2 → 26.3, matching the "Build & Test" job that was already updated in PR #649. The .NET MacCatalyst SDK requires Xcode 26.3, so this fixes the publish job build failures.
Findings (all 🟢 MINOR, all pre-existing)
| # | Finding | Consensus | Severity |
|---|---|---|---|
| 1 | Duplicated Xcode selection logic across two jobs — root cause of needing this PR | 3/3 reviewers | 🟢 MINOR |
| 2 | Empty XCODE_PATH fallback not validated — confusing error if no Xcode 26.x exists |
2/3 reviewers | 🟢 MINOR |
| 3 | Diagnostic ls inconsistency — publish job has it, build-test doesn't |
2/3 reviewers (after follow-up) | 🟢 MINOR |
No bugs, regressions, security issues, or data loss risks were found in the changed code. All findings are pre-existing observations noted for future improvement.
Assessment
- ✅ Both Xcode selection blocks now consistently reference 26.3
- ✅ No remaining references to Xcode 26.2 in any workflow file
- ✅ Fallback glob
Xcode_26*.apphandles future point releases - ✅ No new secrets, permissions, or untrusted input handling
- ✅ Change is a 4-line version bump following the exact pattern already validated in
build-test
Review performed by 3 independent reviewers with adversarial consensus. Discarded findings: none — all flagged items achieved 2/3+ agreement.
Generated by Expert Code Review (auto) for issue #652
PR #649 updated the Build & Test job to Xcode 26.3, but missed the Publish Mac Catalyst App job which still hardcoded Xcode 26.2. The .NET MacCatalyst SDK 26.2.10233 requires Xcode 26.3, causing all Mac Catalyst publish builds to fail since #649 landed.
This is a one-line fix — 26.2 → 26.3 in the publish job's Xcode selection block.
Fixes: Mac Catalyst artifact missing from v1.0.20 release.