Skip to content

Improved Users management#544

Merged
olemp merged 51 commits intodevfrom
feature/admin-add-users
Sep 17, 2020
Merged

Improved Users management#544
olemp merged 51 commits intodevfrom
feature/admin-add-users

Conversation

@olemp
Copy link
Contributor

@olemp olemp commented Sep 17, 2020 •
edited
Loading

Your checklist for this pull request

  • Make sure you are requesting to pull a feature/bugfix branch (right side).
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions locally using npm run watch
  • Make sure strings/resources are added using our resource files

Review checklist

  • Re-create Users table in dev and re-add all Puzzlepart employees using bulk import

Todos

  • Include preferred language, first name and last name for users

Description

Noteable changes

  • Improved UserForm for adding new and editing users
  • Added ImportPanel for importing users in bulk
  • fullName changed to displayName for users in Users
  • Added scope user.read.all so we can retrieve users from AD using Graph
  • Updated sample.env
  • Including more data for users
    image
  • Added two new permission levels manageUsers and manageRolesPermissions

Improved experience

image

image

Bulk import

image

image

@olemp olemp requested a review from a team as a code owner September 17, 2020 08:09
@olemp olemp added this to the Milestone 7: Nitrogen milestone Sep 17, 2020
@olemp olemp added Complexity: medium Issue/PR with medium complexity Priority: medium Issue with medium priority draft labels Sep 17, 2020
@olemp olemp self-assigned this Sep 17, 2020
@olemp olemp requested a review from damsleth September 17, 2020 08:09
@auto-assign auto-assign bot requested review from okms and removed request for a team September 17, 2020 08:10
@olemp olemp marked this pull request as draft September 17, 2020 08:10
@olemp olemp removed the draft label Sep 17, 2020
@olemp olemp removed the draft label Sep 17, 2020
@olemp olemp marked this pull request as ready for review September 17, 2020 15:38
@olemp
Copy link
Contributor Author

olemp commented Sep 17, 2020 •
edited
Loading

@damsleth @okms This is now ready for review again 🚀

  1. Including more data for users

image

image

  1. Added two new permission levels
    image

@olemp olemp marked this pull request as draft September 17, 2020 15:55
@olemp olemp added the draft label Sep 17, 2020
@olemp olemp removed request for damsleth and okms September 17, 2020 15:56
@olemp olemp removed the draft label Sep 17, 2020
@olemp olemp requested a review from damsleth September 17, 2020 16:11
@olemp olemp marked this pull request as ready for review September 17, 2020 16:11
@olemp olemp merged commit 78f2f48 into dev Sep 17, 2020
@olemp olemp deleted the feature/admin-add-users branch September 17, 2020 17:52
olemp added a commit that referenced this pull request Oct 15, 2020
@olemp
Improved Users management (#544)
ca8a33b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damsleth damsleth Awaiting requested review from damsleth

Assignees

@olemp olemp

Labels

Complexity: medium Issue/PR with medium complexity Priority: medium Issue with medium priority

Projects

None yet

Milestone

Milestone 7: Nitrogen

Development

Successfully merging this pull request may close these issues.

2 participants

@olemp @damsleth

Comments